diff options
| author | Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-02-12 08:39:49 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-02-15 00:52:53 (GMT) |
| commit | 814625b539d36d57cb06f412714ec31d7fcd23db (patch) | |
| tree | b8858b8277599cd1bc0f978e1d76c2158ce08a3e | |
| parent | c272dc2da14cde0bfd9495a5aafb8e3e94f35601 (diff) | |
| download | linux-814625b539d36d57cb06f412714ec31d7fcd23db.tar.xz | |
staging: goldfish: goldfish_nand: Return correct error code
The return value of devm_kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.
Found using Coccinelle. A simplified version of the semantic patch
used is:
//<smpl>
@@
expression *e;
@@
e = devm_kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//</smpl>
The single call site does not perform any checks on the return value, hence
no change is required at the call site.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/goldfish/goldfish_nand.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 623353db5..5c4f61c 100644 --- a/drivers/staging/goldfish/goldfish_nand.c +++ b/drivers/staging/goldfish/goldfish_nand.c @@ -290,7 +290,7 @@ static int nand_setup_cmd_params(struct platform_device *pdev, nand->cmd_params = devm_kzalloc(&pdev->dev, sizeof(struct cmd_params), GFP_KERNEL); if (!nand->cmd_params) - return -1; + return -ENOMEM; paddr = __pa(nand->cmd_params); writel((u32)(paddr >> 32), base + NAND_CMD_PARAMS_ADDR_HIGH); |