diff options
| author | Tom Yan <tom.ty89@gmail.com> | 2016-07-06 17:13:08 (GMT) |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2016-07-06 17:32:03 (GMT) |
| commit | a3e8ab1b462d609147afb8df1291e54708593f15 (patch) | |
| tree | 5ddbc49c35267a1197e6ee1e1d68889ed22c9980 | |
| parent | 3e70af86e52e9e9e8fe32027b0471a8da93b498e (diff) | |
| download | linux-a3e8ab1b462d609147afb8df1291e54708593f15.tar.xz | |
libata-scsi: do not respond with "invalid field" for FORMAT UNIT
It does not make sense and is confusing to respond with "Invalid
field in CDB" while we have no support at all implemented for
FORMAT UNIT. It is decent to let it go to the default, which
will respond with "Invalid command operation code" instead.
Signed-off-by: Tom Yan <tom.ty89@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
| -rw-r--r-- | drivers/ata/libata-scsi.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..f1125fd 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -4039,11 +4039,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd) args.done = cmd->scsi_done; switch(scsicmd[0]) { - /* TODO: worth improving? */ - case FORMAT_UNIT: - ata_scsi_invalid_field(dev, cmd, 0); - break; - case INQUIRY: if (scsicmd[1] & 2) /* is CmdDt set? */ ata_scsi_invalid_field(dev, cmd, 1); |