diff options
| author | Josef Bacik <jbacik@fb.com> | 2016-03-25 17:25:51 (GMT) |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2016-07-07 16:45:53 (GMT) |
| commit | d555b6c380c644af63dbdaa7cc14bba041a4e4dd (patch) | |
| tree | 1e323bad2695db3518fe890ebd0d9ec53fbc7613 | |
| parent | c48f49d63dfea12c0173fb2e99db1308f39c23ae (diff) | |
| download | linux-d555b6c380c644af63dbdaa7cc14bba041a4e4dd.tar.xz | |
Btrfs: warn_on for unaccounted spaces
These were hidden behind enospc_debug, which isn't helpful as they indicate
actual bugs, unlike the rest of the enospc_debug stuff which is really debug
information. Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/extent-tree.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index ac80fcc..a1355a3 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -9778,13 +9778,15 @@ int btrfs_free_block_groups(struct btrfs_fs_info *info) space_info = list_entry(info->space_info.next, struct btrfs_space_info, list); - if (btrfs_test_opt(info->tree_root, ENOSPC_DEBUG)) { - if (WARN_ON(space_info->bytes_pinned > 0 || + + /* + * Do not hide this behind enospc_debug, this is actually + * important and indicates a real bug if this happens. + */ + if (WARN_ON(space_info->bytes_pinned > 0 || space_info->bytes_reserved > 0 || - space_info->bytes_may_use > 0)) { - dump_space_info(space_info, 0, 0); - } - } + space_info->bytes_may_use > 0)) + dump_space_info(space_info, 0, 0); list_del(&space_info->list); for (i = 0; i < BTRFS_NR_RAID_TYPES; i++) { struct kobject *kobj; |