summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAli Ayoub <ali@mellanox.co.il>2007-05-17 17:58:30 (GMT)
committerRoland Dreier <rolandd@cisco.com>2007-05-19 15:51:56 (GMT)
commitde57c9f102ad7bdc8afa5a1560748cf4f1c18b8e (patch)
treedccb61b8458206bac0a1c19ce0d9124ff8abd90f
parentbd5a6ccc0e6d8eed3047b4af0e5c1e7168869cd8 (diff)
downloadlinux-de57c9f102ad7bdc8afa5a1560748cf4f1c18b8e.tar.xz
IB/mthca: Fix use-after-free on device restart
Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
-rw-r--r--drivers/infiniband/hw/mthca/mthca_main.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c
index 773145e..aa563e6 100644
--- a/drivers/infiniband/hw/mthca/mthca_main.c
+++ b/drivers/infiniband/hw/mthca/mthca_main.c
@@ -1250,12 +1250,14 @@ static void __mthca_remove_one(struct pci_dev *pdev)
int __mthca_restart_one(struct pci_dev *pdev)
{
struct mthca_dev *mdev;
+ int hca_type;
mdev = pci_get_drvdata(pdev);
if (!mdev)
return -ENODEV;
+ hca_type = mdev->hca_type;
__mthca_remove_one(pdev);
- return __mthca_init_one(pdev, mdev->hca_type);
+ return __mthca_init_one(pdev, hca_type);
}
static int __devinit mthca_init_one(struct pci_dev *pdev,