diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2014-01-23 23:56:13 (GMT) |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-24 00:37:03 (GMT) |
| commit | ed8f68669a27287a3b15882e8d88ebccae75ec59 (patch) | |
| tree | b3d1a78b844e00f6b7640c626dc807a27886a4a3 | |
| parent | b1c8047c6b474c639d923122ab84732cbfeb7225 (diff) | |
| download | linux-ed8f68669a27287a3b15882e8d88ebccae75ec59.tar.xz | |
fs-ext3-use-rbtree-postorder-iteration-helper-instead-of-opencoding-fix
use do{}while - more efficient and it squishes a coccinelle warning
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Michel Lespinasse <walken@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/ext3/dir.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c index a331ad1..e66e480 100644 --- a/fs/ext3/dir.c +++ b/fs/ext3/dir.c @@ -312,11 +312,11 @@ static void free_rb_tree_fname(struct rb_root *root) struct fname *fname, *next; rbtree_postorder_for_each_entry_safe(fname, next, root, rb_hash) - while (fname) { - struct fname * old = fname; + do { + struct fname *old = fname; fname = fname->next; - kfree (old); - } + kfree(old); + } while (fname); *root = RB_ROOT; } |