diff options
| author | Christian Borntraeger <borntraeger@de.ibm.com> | 2013-05-17 12:41:38 (GMT) |
|---|---|---|
| committer | Gleb Natapov <gleb@redhat.com> | 2013-05-21 08:55:38 (GMT) |
| commit | f8b5ff2cff232df052955ef975f7219e1faa217f (patch) | |
| tree | 347954128866e68485eaa1ddedbb24029f86f24f | |
| parent | 7c470539c95630c1f2a10f109e96f249730b75eb (diff) | |
| download | linux-f8b5ff2cff232df052955ef975f7219e1faa217f.tar.xz | |
s390: fix gmap_ipte_notifier vs. software dirty pages
On heavy paging load some guest cpus started to loop in gmap_ipte_notify.
This was visible as stalled cpus inside the guest. The gmap_ipte_notifier
tries to map a user page and then made sure that the pte is valid and
writable. Turns out that with the software change bit tracking the pte
can become read-only (and only software writable) if the page is clean.
Since we loop in this code, the page would stay clean and, therefore,
be never writable again.
Let us just use fixup_user_fault, that guarantees to call handle_mm_fault.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
| -rw-r--r-- | arch/s390/mm/pgtable.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/s390/mm/pgtable.c b/arch/s390/mm/pgtable.c index 5ca7568..1e0c438 100644 --- a/arch/s390/mm/pgtable.c +++ b/arch/s390/mm/pgtable.c @@ -677,8 +677,7 @@ int gmap_ipte_notify(struct gmap *gmap, unsigned long start, unsigned long len) break; } /* Get the page mapped */ - if (get_user_pages(current, gmap->mm, addr, 1, 1, 0, - NULL, NULL) != 1) { + if (fixup_user_fault(current, gmap->mm, addr, FAULT_FLAG_WRITE)) { rc = -EFAULT; break; } |