diff options
| author | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> | 2016-10-21 22:48:41 (GMT) |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2016-11-05 14:57:38 (GMT) |
| commit | 021afd55e2191248b471b29b9d0a96c267939a4d (patch) | |
| tree | 32d7dbbc6c7d2aaf4316e2dc7d9c5e8d49cf2ef6 | |
| parent | 2a1e3b932c5606e2b3671b82eb63929937eb1e0b (diff) | |
| download | linux-021afd55e2191248b471b29b9d0a96c267939a4d.tar.xz | |
HID: intel-ish-hid: request_irq failure
On some platforms ISH interrupt is shared, which causes request_irq to
fail. This requires IRQF_SHARED irq flag.
But IRQF_NO_SUSPEND and IRQF_SHARED should not be used together, so
removed IRQF_NO_SUSPEND flag. Anyway this driver doesn't require
IRQF_NO_SUSPEND, as this interrupt is not required during "noirq" phases
of suspending and resuming devices as well as during the time when
nonboot CPUs are taken offline and brought back online.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/hid/intel-ish-hid/ipc/pci-ish.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c index 7e3622a7..20d647d 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -146,7 +146,7 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent) pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3; /* request and enable interrupt */ - ret = request_irq(pdev->irq, ish_irq_handler, IRQF_NO_SUSPEND, + ret = request_irq(pdev->irq, ish_irq_handler, IRQF_SHARED, KBUILD_MODNAME, dev); if (ret) { dev_err(&pdev->dev, "ISH: request IRQ failure (%d)\n", |