diff options
| author | Jens Axboe <jens.axboe@oracle.com> | 2008-10-01 14:16:25 (GMT) |
|---|---|---|
| committer | Jens Axboe <jens.axboe@oracle.com> | 2008-10-09 06:56:20 (GMT) |
| commit | 0497b345e7d067109e0dd9bf9f4978a6847ee13b (patch) | |
| tree | 8c181a200c9e883a9c85169dff887bfb9109ee5e | |
| parent | ef9e3facdf1fe1228721a7c295a76d1b7a0e57ec (diff) | |
| download | linux-0497b345e7d067109e0dd9bf9f4978a6847ee13b.tar.xz | |
blktrace: use BLKTRACE_BDEV_SIZE as the name size for setup structure
Define as 32, which is is what BDEVNAME_SIZE is/was as well. This keeps
the user interface the same and gets rid of the difference between
kernel and user api here.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
| -rw-r--r-- | block/blktrace.c | 3 | ||||
| -rw-r--r-- | include/linux/blktrace_api.h | 8 |
2 files changed, 5 insertions, 6 deletions
diff --git a/block/blktrace.c b/block/blktrace.c index 9e0212c..85049a7 100644 --- a/block/blktrace.c +++ b/block/blktrace.c @@ -369,7 +369,8 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev, if (!buts->buf_size || !buts->buf_nr) return -EINVAL; - strcpy(buts->name, name); + strncpy(buts->name, name, BLKTRACE_BDEV_SIZE); + buts->name[BLKTRACE_BDEV_SIZE - 1] = '\0'; /* * some device names have larger paths - convert the slashes diff --git a/include/linux/blktrace_api.h b/include/linux/blktrace_api.h index a2a7d0c..3a31eb5 100644 --- a/include/linux/blktrace_api.h +++ b/include/linux/blktrace_api.h @@ -122,15 +122,13 @@ enum { Blktrace_stopped, }; +#define BLKTRACE_BDEV_SIZE 32 + /* * User setup structure passed with BLKTRACESTART */ struct blk_user_trace_setup { -#ifdef __KERNEL__ - char name[BDEVNAME_SIZE]; /* output */ -#else - char name[32]; /* output */ -#endif + char name[BLKTRACE_BDEV_SIZE]; /* output */ __u16 act_mask; /* input */ __u32 buf_size; /* input */ __u32 buf_nr; /* input */ |