diff options
| author | Xin Long <lucien.xin@gmail.com> | 2016-04-08 16:03:30 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-04-14 02:42:32 (GMT) |
| commit | 4436156b6fbec746108d45431a9f1885de810ec1 (patch) | |
| tree | 6b82e56f2367a41c828765392a45159dd35b8ff5 | |
| parent | 347db6b49ec0ba5ee3c9d946d45b7db59cf40480 (diff) | |
| download | linux-4436156b6fbec746108d45431a9f1885de810ec1.tar.xz | |
bridge: simplify the stp_state_store by calling store_bridge_parm
There are some repetitive codes in stp_state_store, we can remove
them by calling store_bridge_parm.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/bridge/br_sysfs_br.c | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index 137cd3b..f9d484e 100644 --- a/net/bridge/br_sysfs_br.c +++ b/net/bridge/br_sysfs_br.c @@ -128,27 +128,21 @@ static ssize_t stp_state_show(struct device *d, } -static ssize_t stp_state_store(struct device *d, - struct device_attribute *attr, const char *buf, - size_t len) +static int set_stp_state(struct net_bridge *br, unsigned long val) { - struct net_bridge *br = to_bridge(d); - char *endp; - unsigned long val; - - if (!ns_capable(dev_net(br->dev)->user_ns, CAP_NET_ADMIN)) - return -EPERM; - - val = simple_strtoul(buf, &endp, 0); - if (endp == buf) - return -EINVAL; - if (!rtnl_trylock()) return restart_syscall(); br_stp_set_enabled(br, val); rtnl_unlock(); - return len; + return 0; +} + +static ssize_t stp_state_store(struct device *d, + struct device_attribute *attr, const char *buf, + size_t len) +{ + return store_bridge_parm(d, buf, len, set_stp_state); } static DEVICE_ATTR_RW(stp_state); |