diff options
| author | Wei Yongjun <weiyj.lk@gmail.com> | 2016-08-03 10:58:35 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-08-06 04:07:38 (GMT) |
| commit | 54447f1ad73414ebb052e9a33d079cabed3a03e8 (patch) | |
| tree | 1a477222c5c8636fc383d8bb8a7792e7d514b3ee | |
| parent | 5ef9f289c4e698054e5687edb54f0da3cdc9173a (diff) | |
| download | linux-54447f1ad73414ebb052e9a33d079cabed3a03e8.tar.xz | |
net: arc_emac: add missing of_node_put() in arc_emac_probe()
commit a94efbd7cc45 ("ethernet: arc: emac_main: add missing of_node_put
after calling of_parse_phandle") added missing of_node_put after calling
of_parse_phandle, but missing the devm_ioremap_resource() error handling
case.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/arc/emac_main.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index 4bff0f3..b0da969 100644 --- a/drivers/net/ethernet/arc/emac_main.c +++ b/drivers/net/ethernet/arc/emac_main.c @@ -771,8 +771,10 @@ int arc_emac_probe(struct net_device *ndev, int interface) priv->dev = dev; priv->regs = devm_ioremap_resource(dev, &res_regs); - if (IS_ERR(priv->regs)) - return PTR_ERR(priv->regs); + if (IS_ERR(priv->regs)) { + err = PTR_ERR(priv->regs); + goto out_put_node; + } dev_dbg(dev, "Registers base address is 0x%p\n", priv->regs); |