summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Retanubun <RichardRetanubun@ruggedcom.com>2011-03-17 21:39:28 (GMT)
committerGreg Kroah-Hartman <gregkh@suse.de>2011-04-13 22:57:19 (GMT)
commit5808544690300071f09eef9ab83a0fb1f60cf1cd (patch)
tree8fb721b3a6ce9e9ce613c961543a3d3dc92519bf
parentd834508e159fe8936f9e7fd941b1e2fe9a209d4b (diff)
downloadlinux-5808544690300071f09eef9ab83a0fb1f60cf1cd.tar.xz
USB: isp1760-hcd: move imask clear after pending work is done
This patch moves the HcInterrupt register write to clear the pending interrupt to after the isr work is done, doing this removes glitches in the irq line. Signed-off-by: Richard Retanubun <richardretanubun@ruggedcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/host/isp1760-hcd.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index 795345a..564b033 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -1676,13 +1676,15 @@ static irqreturn_t isp1760_irq(struct usb_hcd *hcd)
if (unlikely(!imask))
goto leave;
- reg_write32(hcd->regs, HC_INTERRUPT_REG, imask);
if (imask & (HC_ATL_INT | HC_SOT_INT))
do_atl_int(hcd);
if (imask & HC_INTL_INT)
do_intl_int(hcd);
+ /* Clear interrupt mask on device after the work is done */
+ reg_write32(hcd->regs, HC_INTERRUPT_REG, imask);
+
irqret = IRQ_HANDLED;
leave:
spin_unlock(&priv->lock);