diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-11-26 22:34:43 (GMT) |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2014-11-27 08:34:41 (GMT) |
| commit | 69eba10e606a80665f8573221fec589430d9d1cb (patch) | |
| tree | a64f2fe22e666d788d268274f256bdd350f26355 | |
| parent | 51e6f47dd2e3463dac6f37128fd7b7cb40c500de (diff) | |
| download | linux-69eba10e606a80665f8573221fec589430d9d1cb.tar.xz | |
ALSA: hda - using uninitialized data
In olden times the snd_hda_param_read() function always set "*start_id"
but in 2007 we introduced a new return and it causes uninitialized data
bugs in a couple of the callers: print_codec_info() and
hdmi_parse_codec().
Fixes: e8a7f136f5ed ('[ALSA] hda-intel - Improve HD-audio codec probing robustness')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/hda/hda_codec.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index b2d5899..2fe86d2 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -346,8 +346,10 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid, unsigned int parm; parm = snd_hda_param_read(codec, nid, AC_PAR_NODE_COUNT); - if (parm == -1) + if (parm == -1) { + *start_id = 0; return 0; + } *start_id = (parm >> 16) & 0x7fff; return (int)(parm & 0x7fff); } |