diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-02-24 18:00:51 (GMT) |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-04-18 15:55:31 (GMT) |
| commit | 7c1fca336661aaeb70b9094c4b8eaae389027509 (patch) | |
| tree | 42280426496b607a08d3fa5689a2107bf5f1738b | |
| parent | bd7dee6311156b7cdf884344feb34628909398ad (diff) | |
| download | linux-7c1fca336661aaeb70b9094c4b8eaae389027509.tar.xz | |
firewire: fw-sbp2: fix reference counting
The reference count of the unit dropped too low in an error path in
sbp2_probe. Fixed by moving the _get further up.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
| -rw-r--r-- | drivers/firewire/fw-sbp2.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/firewire/fw-sbp2.c b/drivers/firewire/fw-sbp2.c index 62b4e47..8fff18e 100644 --- a/drivers/firewire/fw-sbp2.c +++ b/drivers/firewire/fw-sbp2.c @@ -1119,6 +1119,7 @@ static int sbp2_probe(struct device *dev) goto fail_shost_put; fw_device_get(device); + get_device(&unit->device); /* Initialize to values that won't match anything in our table. */ firmware_revision = 0xff000000; @@ -1134,8 +1135,6 @@ static int sbp2_probe(struct device *dev) sbp2_init_workarounds(tgt, model, firmware_revision); - get_device(&unit->device); - /* Do the login in a workqueue so we can easily reschedule retries. */ list_for_each_entry(lu, &tgt->lu_list, link) sbp2_queue_work(lu, 0); |