diff options
| author | Julia Lawall <julia@diku.dk> | 2009-12-27 11:27:44 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-01-04 05:42:49 (GMT) |
| commit | ce739b473ce12d5ef067b39b8637bfd2b2174a15 (patch) | |
| tree | cc95857da8afed8c429e9644977734c9b35f818f | |
| parent | 073bd90f03d98bc3168865f21573c9b232777c13 (diff) | |
| download | linux-ce739b473ce12d5ef067b39b8637bfd2b2174a15.tar.xz | |
drivers/net/can: Correct NULL test
Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,y;
statement S;
@@
x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
- y
+ x
== NULL)
S
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Oliver Hartkopp <oliver@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/can/mcp251x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c index 9c5a153..1a72ca0 100644 --- a/drivers/net/can/mcp251x.c +++ b/drivers/net/can/mcp251x.c @@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(struct spi_device *spi) goto error_tx_buf; } priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL); - if (!priv->spi_tx_buf) { + if (!priv->spi_rx_buf) { ret = -ENOMEM; goto error_rx_buf; } |