diff options
| author | Daniel Mack <daniel@zonque.org> | 2014-10-07 11:41:23 (GMT) |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2014-10-07 12:12:28 (GMT) |
| commit | decc27b01d584c985c231e73d3b493de6ec07af8 (patch) | |
| tree | f8a453869deb5eea00e7f41ec4f1f8de5c492be2 | |
| parent | 6596aa047b624aeec2ea321962cfdecf9953a383 (diff) | |
| download | linux-decc27b01d584c985c231e73d3b493de6ec07af8.tar.xz | |
ASoC: core: fix use after free in snd_soc_remove_platform()
Coverity spotted an use-after-free condition in snd_soc_remove_platform().
Fix this by moving snd_soc_component_cleanup() after the debug print
statement which uses the component's string.
Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
| -rw-r--r-- | sound/soc/soc-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index ae48f10..d877ec5 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -4315,10 +4315,10 @@ void snd_soc_remove_platform(struct snd_soc_platform *platform) snd_soc_component_del_unlocked(&platform->component); mutex_unlock(&client_mutex); - snd_soc_component_cleanup(&platform->component); - dev_dbg(platform->dev, "ASoC: Unregistered platform '%s'\n", platform->component.name); + + snd_soc_component_cleanup(&platform->component); } EXPORT_SYMBOL_GPL(snd_soc_remove_platform); |