diff options
| author | Hans Verkuil <hans.verkuil@cisco.com> | 2014-02-03 14:22:45 (GMT) |
|---|---|---|
| committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-03-11 09:56:43 (GMT) |
| commit | e4d2581649fe87bbd506c4d55591c4de9d2962d8 (patch) | |
| tree | 53a18a8f0953fbb0ab8e5445f9457e2bced64502 | |
| parent | fb64dca805f091b52dbe8d6504390f63d961cbbd (diff) | |
| download | linux-e4d2581649fe87bbd506c4d55591c4de9d2962d8.tar.xz | |
[media] vb2: replace BUG by WARN_ON
No need to oops for this, WARN_ON is good enough.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
| -rw-r--r-- | drivers/media/v4l2-core/videobuf2-core.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 17f1d07..f8fe1d9 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -2597,9 +2597,9 @@ static int __vb2_init_fileio(struct vb2_queue *q, int read) /* * Sanity check */ - if ((read && !(q->io_modes & VB2_READ)) || - (!read && !(q->io_modes & VB2_WRITE))) - BUG(); + if (WARN_ON((read && !(q->io_modes & VB2_READ)) || + (!read && !(q->io_modes & VB2_WRITE)))) + return -EINVAL; /* * Check if device supports mapping buffers to kernel virtual space. |