summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjohn.maxin@nokia.com <john.maxin@nokia.com>2011-05-06 09:17:21 (GMT)
committerDavid Woodhouse <David.Woodhouse@intel.com>2011-05-25 01:01:38 (GMT)
commiteff3bba61fc19a64a1ca56343e38b6506bef9dea (patch)
tree10f2c7cabc65d4385cedc76ee95b0eb7ad279cf0
parent26d9be11485ea8c1102c3e8eaa7667412eef4950 (diff)
downloadlinux-eff3bba61fc19a64a1ca56343e38b6506bef9dea.tar.xz
mtd: onenand: add missing check
Coverity has reported that inside the function "onenand_block_by_block_erase()" in onenand_base.c, we should add a check to prevent the incrementing of possible NULL value for "region" Signed-off-by: Maxin B. John <john.maxin@nokia.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
-rw-r--r--drivers/mtd/onenand/onenand_base.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index d27f93b..289ee3b 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2453,7 +2453,7 @@ static int onenand_block_by_block_erase(struct mtd_info *mtd,
len -= block_size;
addr += block_size;
- if (addr == region_end) {
+ if (region && addr == region_end) {
if (!len)
break;
region++;