diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-22 14:48:33 (GMT) |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2016-01-11 07:53:10 (GMT) |
| commit | 0c7f3f92ffe8dc4e631b2f20c06543ec9f521f7c (patch) | |
| tree | c8f55467871f03f6ead604fbd442172bc0491824 | |
| parent | a5dca7dc7e80f0cb4dcc9251983fb51745541f48 (diff) | |
| download | linux-0c7f3f92ffe8dc4e631b2f20c06543ec9f521f7c.tar.xz | |
mfd: ucb1x00-core: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/ucb1x00-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c index f691d7e..e0dd83f 100644 --- a/drivers/mfd/ucb1x00-core.c +++ b/drivers/mfd/ucb1x00-core.c @@ -133,7 +133,7 @@ static int ucb1x00_gpio_get(struct gpio_chip *chip, unsigned offset) val = ucb1x00_reg_read(ucb, UCB_IO_DATA); ucb1x00_disable(ucb); - return val & (1 << offset); + return !!(val & (1 << offset)); } static int ucb1x00_gpio_direction_input(struct gpio_chip *chip, unsigned offset) |