summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>2016-03-02 20:02:14 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-03-02 23:28:13 (GMT)
commit5210a63ad9e58139ef378bb6668f2467e307fc70 (patch)
tree150739db7a0ee3f31f27f3e6cd4b80507d1525de
parent7cadcc7c32f625403b58e23ab413dec330e34d92 (diff)
downloadlinux-5210a63ad9e58139ef378bb6668f2467e307fc70.tar.xz
staging: lustre: llite: Remove unnecessary test in if condition
Remove unnecessary test on `rc` variable since it has already been tested previously. Fixes following smatch warning: drivers/staging/lustre/lustre/llite/llite_lib.c:1331 ll_setattr_raw() warn: we tested 'rc' before and it was 'false' Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/lustre/lustre/llite/llite_lib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index acdae25..6d6bb33 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -1328,7 +1328,7 @@ int ll_setattr_raw(struct dentry *dentry, struct iattr *attr, bool hsm_import)
}
/* RPC to MDT is sent, cancel data modification flag */
- if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) {
+ if (op_data->op_bias & MDS_DATA_MODIFIED) {
spin_lock(&lli->lli_lock);
lli->lli_flags &= ~LLIF_DATA_MODIFIED;
spin_unlock(&lli->lli_lock);