summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKen Cox <jkc@redhat.com>2014-07-03 15:02:16 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-07-08 22:37:59 (GMT)
commit548950a26123d917346ba1284a21e6de0ee136b3 (patch)
treec3b6b14b51b1311fe6b01181324757f44da3a3aa
parent960e0a5fbbd748ab1333cee716c92d91d28e287f (diff)
downloadlinux-548950a26123d917346ba1284a21e6de0ee136b3.tar.xz
Staging: unisys: Remove isServer arg from init_vbus_channel()
The init_vbus_channel() function is never called with the isServer argument equal to TRUE, so just get rid of the argument altogether. This also means that the code in the function that would be executed in the server case can be removed since it is never executed. Signed-off-by: Ken Cox <jkc@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/unisys/uislib/uislib.c26
1 files changed, 7 insertions, 19 deletions
diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/staging/unisys/uislib/uislib.c
index 70cc00f..5c7bffc 100644
--- a/drivers/staging/unisys/uislib/uislib.c
+++ b/drivers/staging/unisys/uislib/uislib.c
@@ -129,7 +129,7 @@ init_msg_header(CONTROLVM_MESSAGE *msg, U32 id, uint rsp, uint svr)
}
static __iomem void *
-init_vbus_channel(U64 channelAddr, U32 channelBytes, int isServer)
+init_vbus_channel(U64 channelAddr, U32 channelBytes)
{
void __iomem *rc = NULL;
void __iomem *pChan = uislib_ioremap_cache(channelAddr, channelBytes);
@@ -140,22 +140,11 @@ init_vbus_channel(U64 channelAddr, U32 channelBytes, int isServer)
rc = NULL;
goto Away;
}
- if (isServer) {
- memset_io(pChan, 0, channelBytes);
- if (!ULTRA_VBUS_CHANNEL_OK_SERVER(channelBytes, NULL)) {
- ERRDRV("%s channel cannot be used", __func__);
- uislib_iounmap(pChan);
- rc = NULL;
- goto Away;
- }
- ultra_vbus_init_channel(pChan, channelBytes);
- } else {
- if (!ULTRA_VBUS_CHANNEL_OK_CLIENT(pChan, NULL)) {
- ERRDRV("%s channel cannot be used", __func__);
- uislib_iounmap(pChan);
- rc = NULL;
- goto Away;
- }
+ if (!ULTRA_VBUS_CHANNEL_OK_CLIENT(pChan, NULL)) {
+ ERRDRV("%s channel cannot be used", __func__);
+ uislib_iounmap(pChan);
+ rc = NULL;
+ goto Away;
}
rc = pChan;
Away:
@@ -235,8 +224,7 @@ create_bus(CONTROLVM_MESSAGE *msg, char *buf)
bus->busChannelBytes = msg->cmd.createBus.channelBytes;
bus->pBusChannel =
init_vbus_channel(msg->cmd.createBus.channelAddr,
- msg->cmd.createBus.channelBytes,
- msg->hdr.Flags.server);
+ msg->cmd.createBus.channelBytes);
}
/* the msg is bound for virtpci; send guest_msgs struct to callback */
if (!msg->hdr.Flags.server) {