summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2013-09-04 12:17:08 (GMT)
committerLinus Walleij <linus.walleij@linaro.org>2013-09-04 12:22:47 (GMT)
commit65d876564e989b63b0f769e0e06b9830db97b2d9 (patch)
tree2549b0ba6ad1aa90f049cdc35ebf75ddd50b6271
parentbe1a4b13089b1e18da83a549d49163ccad3c19ba (diff)
downloadlinux-65d876564e989b63b0f769e0e06b9830db97b2d9.tar.xz
gpio: return -ENOTSUPP if debounce cannot be set
It appears some drivers are using gpio_set_debounce() opportunistically, i.e. without knowing whether it works or not. (Example: input/keyboard/gpio_keys.c) to account for this use case, return -ENOTSUPP and do not print any warnings in this case. Took a round over the other gpio_set_debounce() consumers to make sure that none of them are relying on the returned error code to be something specific. Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/gpio/gpiolib.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 0cbddda..86ef346 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1763,6 +1763,9 @@ EXPORT_SYMBOL_GPL(gpio_direction_output);
* gpio_set_debounce - sets @debounce time for a @gpio
* @gpio: the gpio to set debounce time
* @debounce: debounce time is microseconds
+ *
+ * returns -ENOTSUPP if the controller does not support setting
+ * debounce.
*/
static int gpiod_set_debounce(struct gpio_desc *desc, unsigned debounce)
{
@@ -1778,9 +1781,9 @@ static int gpiod_set_debounce(struct gpio_desc *desc, unsigned debounce)
chip = desc->chip;
if (!chip->set || !chip->set_debounce) {
- pr_warn("%s: missing set() or set_debounce() operations\n",
+ pr_debug("%s: missing set() or set_debounce() operations\n",
__func__);
- return -EIO;
+ return -ENOTSUPP;
}
spin_lock_irqsave(&gpio_lock, flags);