diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-06-11 08:50:01 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-06-11 22:44:41 (GMT) |
| commit | 7ec0bb227aa6fb8c622bec91933e865b37dc58f2 (patch) | |
| tree | af1d96bb2179c5973efee4d46ff6136ffbc82901 | |
| parent | f60a8b3d1968d3e2d5259e2c2d4e9f16e19a738b (diff) | |
| download | linux-7ec0bb227aa6fb8c622bec91933e865b37dc58f2.tar.xz | |
net/mlx5_core: fix an error code
We return success if mlx5e_alloc_sq_db() fails but we should return an
error code.
Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 7348c51..075e517 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -525,7 +525,8 @@ static int mlx5e_create_sq(struct mlx5e_channel *c, sq->uar_map = sq->uar.map; sq->bf_buf_size = (1 << MLX5_CAP_GEN(mdev, log_bf_reg_size)) / 2; - if (mlx5e_alloc_sq_db(sq, cpu_to_node(c->cpu))) + err = mlx5e_alloc_sq_db(sq, cpu_to_node(c->cpu)); + if (err) goto err_sq_wq_destroy; sq->txq = netdev_get_tx_queue(priv->netdev, |