diff options
| author | J. Bruce Fields <bfields@citi.umich.edu> | 2008-05-05 23:47:29 (GMT) |
|---|---|---|
| committer | J. Bruce Fields <bfields@citi.umich.edu> | 2008-05-18 23:13:07 (GMT) |
| commit | 88dd0be3874566796fa4ffbdf927a53c4a6a2f4b (patch) | |
| tree | 29cb36a8d21d274e5a7dbd11ec69da225d328c65 | |
| parent | b8291ad07a7f3b5b990900f0001198ac23ba893e (diff) | |
| download | linux-88dd0be3874566796fa4ffbdf927a53c4a6a2f4b.tar.xz | |
nfsd: reorder printk in do_probe_callback to avoid use-after-free
We're currently dereferencing the client after we drop our reference
count to it.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
| -rw-r--r-- | fs/nfsd/nfs4callback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 0b3ffa9..4d4760e 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -419,9 +419,9 @@ static int do_probe_callback(void *data) out_release_client: rpc_shutdown_client(client); out_err: - put_nfs4_client(clp); dprintk("NFSD: warning: no callback path to client %.*s\n", (int)clp->cl_name.len, clp->cl_name.data); + put_nfs4_client(clp); return status; } |