diff options
| author | Russell King <rmk+kernel@arm.linux.org.uk> | 2014-07-07 23:22:39 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-07-08 04:21:21 (GMT) |
| commit | 9671a42e4508db8a0196110b098fd8550304ab14 (patch) | |
| tree | 399a3c63fc22a897f70dc10fbf00218c49da2e12 | |
| parent | b44592ffb8e0da32f1d17f1586a9d2c59dd152a1 (diff) | |
| download | linux-9671a42e4508db8a0196110b098fd8550304ab14.tar.xz | |
net: fec: fix ethtool set_pauseparam duplex bug
Setting the pause parameters causes a running network interface to be
restarted. However, the restart forces the FEC into half-duplex mode,
whether or not the remote end is in half-duplex mode. Misconfigured
duplex mode is a known source of problems on a link.
Fix this by always preserving the duplex mode on configuration changes.
Acked-by: Fugang Duan <B38611@freescale.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index a91fe68..045ea71 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1897,7 +1897,7 @@ static int fec_enet_set_pauseparam(struct net_device *ndev, phy_start_aneg(fep->phy_dev); } if (netif_running(ndev)) - fec_restart(ndev, 0); + fec_restart(ndev, fep->full_duplex); return 0; } |