diff options
| author | Asias He <asias@redhat.com> | 2013-05-07 06:51:49 (GMT) |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2013-05-07 08:11:08 (GMT) |
| commit | a18cc421649dfdc21edb6c4c867dd05447d7df8c (patch) | |
| tree | e7509de7899b4ff9c10e40c5db95486575e5a334 | |
| parent | 7542a6b0d273ba4338028d39bc0e6e8cbfc68898 (diff) | |
| download | linux-a18cc421649dfdc21edb6c4c867dd05447d7df8c.tar.xz | |
vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX
It was disabled as a workaround. Now userspace bits work fine with it.
The broken version was not ever committed to QEMU, I guess the same is
true for nlkt.
So, let's enable it.
Signed-off-by: Asias He <asias@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | drivers/vhost/scsi.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 5179f7a..7014202 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -162,14 +162,8 @@ enum { VHOST_SCSI_VQ_IO = 2, }; -/* - * VIRTIO_RING_F_EVENT_IDX seems broken. Not sure the bug is in - * kernel but disabling it helps. - * TODO: debug and remove the workaround. - */ enum { - VHOST_SCSI_FEATURES = (VHOST_FEATURES & (~VIRTIO_RING_F_EVENT_IDX)) | - (1ULL << VIRTIO_SCSI_F_HOTPLUG) + VHOST_SCSI_FEATURES = VHOST_FEATURES | (1ULL << VIRTIO_SCSI_F_HOTPLUG) }; #define VHOST_SCSI_MAX_TARGET 256 |