diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-22 14:48:13 (GMT) |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2016-01-14 08:43:13 (GMT) |
| commit | bf3de47f1af3dab8fb8c3a3bd21ada7de614b7de (patch) | |
| tree | 91bca3f986531669bcfab864ec59bbd5c0121c49 | |
| parent | 0c7f3f92ffe8dc4e631b2f20c06543ec9f521f7c (diff) | |
| download | linux-bf3de47f1af3dab8fb8c3a3bd21ada7de614b7de.tar.xz | |
mfd: tps65010: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
This also start to propagate the negative error code from the
smbus call if there is one, as the last commit of this series
will make the gpiolib core deal with that properly.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/tps65010.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c index 448f0a1..677a127 100644 --- a/drivers/mfd/tps65010.c +++ b/drivers/mfd/tps65010.c @@ -499,11 +499,11 @@ static int tps65010_gpio_get(struct gpio_chip *chip, unsigned offset) if (offset < 4) { value = i2c_smbus_read_byte_data(tps->client, TPS_DEFGPIO); if (value < 0) - return 0; + return value; if (value & (1 << (offset + 4))) /* output */ return !(value & (1 << offset)); else /* input */ - return (value & (1 << offset)); + return !!(value & (1 << offset)); } /* REVISIT we *could* report LED1/nPG and LED2 state ... */ |