diff options
| author | Fabio Estevam <fabio.estevam@freescale.com> | 2013-07-21 16:25:00 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-07-22 23:50:31 (GMT) |
| commit | d265cf48ea0a5cf6d201abb0bfab6674019126d4 (patch) | |
| tree | 1cac3a245cdd6262f24f9074b79854c1b7207120 | |
| parent | 9514fe7a2352e35ff571467afba24ab904a1befe (diff) | |
| download | linux-d265cf48ea0a5cf6d201abb0bfab6674019126d4.tar.xz | |
fec: Fix the order for enabling/disabling the clocks
On fec_probe the clocks are enabled in the following order:
clk_ahb -> clk_ipg -> clk_enet_out -> clk_ptp
, so in the error and remove paths we should disabled them in the opposite
order.
Also fix the order in the suspend/resume functions.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index beaa576..5c34fd8 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2179,12 +2179,12 @@ failed_init: if (fep->reg_phy) regulator_disable(fep->reg_phy); failed_regulator: - clk_disable_unprepare(fep->clk_ahb); - clk_disable_unprepare(fep->clk_ipg); - if (fep->clk_enet_out) - clk_disable_unprepare(fep->clk_enet_out); if (fep->clk_ptp) clk_disable_unprepare(fep->clk_ptp); + if (fep->clk_enet_out) + clk_disable_unprepare(fep->clk_enet_out); + clk_disable_unprepare(fep->clk_ipg); + clk_disable_unprepare(fep->clk_ahb); failed_clk: failed_ioremap: free_netdev(ndev); @@ -2216,8 +2216,8 @@ fec_drv_remove(struct platform_device *pdev) ptp_clock_unregister(fep->ptp_clock); if (fep->clk_enet_out) clk_disable_unprepare(fep->clk_enet_out); - clk_disable_unprepare(fep->clk_ahb); clk_disable_unprepare(fep->clk_ipg); + clk_disable_unprepare(fep->clk_ahb); free_netdev(ndev); return 0; @@ -2236,8 +2236,8 @@ fec_suspend(struct device *dev) } if (fep->clk_enet_out) clk_disable_unprepare(fep->clk_enet_out); - clk_disable_unprepare(fep->clk_ahb); clk_disable_unprepare(fep->clk_ipg); + clk_disable_unprepare(fep->clk_ahb); if (fep->reg_phy) regulator_disable(fep->reg_phy); @@ -2258,10 +2258,10 @@ fec_resume(struct device *dev) return ret; } - if (fep->clk_enet_out) - clk_prepare_enable(fep->clk_enet_out); clk_prepare_enable(fep->clk_ahb); clk_prepare_enable(fep->clk_ipg); + if (fep->clk_enet_out) + clk_prepare_enable(fep->clk_enet_out); if (netif_running(ndev)) { fec_restart(ndev, fep->full_duplex); netif_device_attach(ndev); |