summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Gartrell <agartrell@fb.com>2014-10-06 20:30:08 (GMT)
committerSimon Horman <simon.horman@netronome.com>2014-10-28 00:50:06 (GMT)
commitd7701089118d23bfed03bad0a6b5cc5115990c9e (patch)
treedef2ac0f48a3eaabf1dd8dc0439bb9cd7e5a7226
parent61ed53deb1c6a4386d8710dbbfcee8779c381931 (diff)
downloadlinux-d7701089118d23bfed03bad0a6b5cc5115990c9e.tar.xz
ipvs: remove unnecessary assignment in __ip_vs_get_out_rt
It is a precondition of the function that daddr be equal to dest->addr.ip if dest is non-NULL, so this additional assignment is just confusing for stupid engineers like me. Signed-off-by: Alex Gartrell <agartrell@fb.com> Signed-off-by: Simon Horman <horms@verge.net.au>
-rw-r--r--net/netfilter/ipvs/ip_vs_xmit.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index 91f17c1..5efa597 100644
--- a/net/netfilter/ipvs/ip_vs_xmit.c
+++ b/net/netfilter/ipvs/ip_vs_xmit.c
@@ -293,7 +293,6 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest,
&dest->addr.ip, &dest_dst->dst_saddr.ip,
atomic_read(&rt->dst.__refcnt));
}
- daddr = dest->addr.ip;
if (ret_saddr)
*ret_saddr = dest_dst->dst_saddr.ip;
} else {