diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2012-05-06 12:28:26 (GMT) |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-05-14 12:35:17 (GMT) |
| commit | 1b3bbcf5ab7250527a629ec1ffc36c8d1ea12681 (patch) | |
| tree | 3089b1fa7c58d479b64a2afebd1d9e966d48aa91 | |
| parent | 55db765c54cd9506524c2945e3905fcf9215ea71 (diff) | |
| download | linux-1b3bbcf5ab7250527a629ec1ffc36c8d1ea12681.tar.xz | |
[media] gspca_zc3xx: Disable the highest quality setting as it is not usable
Even with BRC the highest quality setting is not usable, BRC strips so
much data from each MCU that the quality becomes worse then using a lower
quality setting to begin with.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/video/gspca/zc3xx.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/media/video/gspca/zc3xx.c b/drivers/media/video/gspca/zc3xx.c index 54735dd..998017e 100644 --- a/drivers/media/video/gspca/zc3xx.c +++ b/drivers/media/video/gspca/zc3xx.c @@ -194,7 +194,7 @@ static const struct ctrl sd_ctrls[NCTRLS] = { .type = V4L2_CTRL_TYPE_INTEGER, .name = "Compression Quality", .minimum = 50, - .maximum = 94, + .maximum = 87, .step = 1, .default_value = 75, }, @@ -241,8 +241,11 @@ static const struct v4l2_pix_format sif_mode[] = { .priv = 0}, }; -/* bridge reg08 bits 1-2 -> JPEG quality conversion table */ -static u8 jpeg_qual[] = {50, 75, 87, 94}; +/* + * Bridge reg08 bits 1-2 -> JPEG quality conversion table. Note the highest + * quality setting is not usable as USB 1 does not have enough bandwidth. + */ +static u8 jpeg_qual[] = {50, 75, 87, /* 94 */}; /* usb exchanges */ struct usb_action { |