diff options
| author | Muhammad Falak R Wani <falakreyaz@gmail.com> | 2015-09-05 14:23:27 (GMT) |
|---|---|---|
| committer | Jacek Anaszewski <j.anaszewski@samsung.com> | 2015-11-03 07:59:13 (GMT) |
| commit | 583a2b2cd73c13a91b5f529466dec4d27716d226 (patch) | |
| tree | 7cc9056db93ccff6b502fe5826d0fee88850f1c3 | |
| parent | c0fc68ba97b0f96fa4aaa6010ead6b77d3ffc3dd (diff) | |
| download | linux-583a2b2cd73c13a91b5f529466dec4d27716d226.tar.xz | |
leds: leds-ot200: Use devm_led_classdev_register
Use resource-managed function devm_led_classdev_register
instead of led_classdev_register to make the error path simpler.
The goto is replaced with direct return, unneeded label err is
dropped. Also, remove redundant ot200_led_remove.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
| -rw-r--r-- | drivers/leds/leds-ot200.c | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c index 39870de..12af112 100644 --- a/drivers/leds/leds-ot200.c +++ b/drivers/leds/leds-ot200.c @@ -124,9 +124,9 @@ static int ot200_led_probe(struct platform_device *pdev) leds[i].cdev.name = leds[i].name; leds[i].cdev.brightness_set = ot200_led_brightness_set; - ret = led_classdev_register(&pdev->dev, &leds[i].cdev); + ret = devm_led_classdev_register(&pdev->dev, &leds[i].cdev); if (ret < 0) - goto err; + return ret; } leds_front = 0; /* turn off all front leds */ @@ -135,27 +135,10 @@ static int ot200_led_probe(struct platform_device *pdev) outb(leds_back, 0x5a); return 0; - -err: - for (i = i - 1; i >= 0; i--) - led_classdev_unregister(&leds[i].cdev); - - return ret; -} - -static int ot200_led_remove(struct platform_device *pdev) -{ - int i; - - for (i = 0; i < ARRAY_SIZE(leds); i++) - led_classdev_unregister(&leds[i].cdev); - - return 0; } static struct platform_driver ot200_led_driver = { .probe = ot200_led_probe, - .remove = ot200_led_remove, .driver = { .name = "leds-ot200", }, |