summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2016-07-19 13:24:50 (GMT)
committerGreg Kroah-Hartman <gregkh@google.com>2016-07-20 02:06:34 (GMT)
commit6633d80afbeecd91d5d786d6fbb32cdb8bc0a567 (patch)
tree846205eed426faa3f6e52d593d632523fe618aed
parentc80a982fc1f8b2b1546c4b2acc08ffd543f6f6c5 (diff)
downloadlinux-6633d80afbeecd91d5d786d6fbb32cdb8bc0a567.tar.xz
greybus: module: suppress activation error message for dummy interfaces
We currently handle dummy interfaces by deactivating them using activation error paths, but we don't want the corresponding module_inserted error message to be printed. Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
-rw-r--r--drivers/staging/greybus/module.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/staging/greybus/module.c b/drivers/staging/greybus/module.c
index 7f0ed9f..242be49 100644
--- a/drivers/staging/greybus/module.c
+++ b/drivers/staging/greybus/module.c
@@ -153,8 +153,11 @@ static void gb_module_register_interface(struct gb_interface *intf)
break;
}
if (ret) {
- dev_err(&module->dev, "failed to activate interface %u: %d\n",
- intf_id, ret);
+ if (intf->type != GB_SVC_INTF_TYPE_DUMMY) {
+ dev_err(&module->dev,
+ "failed to activate interface %u: %d\n",
+ intf_id, ret);
+ }
/*
* -EAGAIN indicates that the Greybus operation