diff options
| author | Laurentiu Tudor <laurentiu.tudor@nxp.com> | 2017-02-07 15:43:45 (GMT) |
|---|---|---|
| committer | Xie Xiaobo <xiaobo.xie@nxp.com> | 2017-07-14 10:37:11 (GMT) |
| commit | 7991db27e9ec059b94bb02d810e1f516e2b8a25b (patch) | |
| tree | 782426eb8aad1c9103863f7d2e861204f8d1b2db | |
| parent | 8716ded1981e37ab65050dc91681abcfcfa16876 (diff) | |
| download | linux-7991db27e9ec059b94bb02d810e1f516e2b8a25b.tar.xz | |
staging: fsl-mc: fix device ref counting
Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: Stuart Yoder <stuart.yoder@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/fsl-mc/bus/dprc-driver.c | 1 | ||||
| -rw-r--r-- | drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c index 4e416d8..e4b0341 100644 --- a/drivers/staging/fsl-mc/bus/dprc-driver.c +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c @@ -188,6 +188,7 @@ static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev, child_dev = fsl_mc_device_lookup(obj_desc, mc_bus_dev); if (child_dev) { check_plugged_state_change(child_dev, obj_desc); + put_device(&child_dev->dev); continue; } diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c index cc20dc4..7c6a43b 100644 --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c @@ -537,7 +537,6 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, goto error_cleanup_dev; } - (void)get_device(&mc_dev->dev); dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev)); *new_mc_dev = mc_dev; |