diff options
| author | Tyrel Datwyler <tyreld@linux.vnet.ibm.com> | 2017-04-18 00:29:17 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-25 13:44:37 (GMT) |
| commit | 80cdf2065bf0e10862b400715672555ef3e49a3e (patch) | |
| tree | 67afa04e16a866627271c8865a19ffb78756a070 | |
| parent | ae5074ba9ef8043e17a13c32402e7a80ef7aafb4 (diff) | |
| download | linux-80cdf2065bf0e10862b400715672555ef3e49a3e.tar.xz | |
of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
commit b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 upstream.
The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.
This patch adds an of_node_put() to release the reference.
fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/of/of_numa.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c index a53982a..2db1f7a 100644 --- a/drivers/of/of_numa.c +++ b/drivers/of/of_numa.c @@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void) else node_set(nid, numa_nodes_parsed); } + + of_node_put(cpus); } static int __init of_numa_parse_memory_nodes(void) |