diff options
| author | Felipe Balbi <balbi@ti.com> | 2014-11-20 16:12:32 (GMT) |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2014-11-20 16:12:32 (GMT) |
| commit | a4722fd3f2d3590af5200890b61dbbdf87480abb (patch) | |
| tree | 6f24ac4b74a5816608ac69e748f51d6fa831de9a | |
| parent | f905bc68833b37b2274dc269fd35edb19e67aed7 (diff) | |
| download | linux-a4722fd3f2d3590af5200890b61dbbdf87480abb.tar.xz | |
usb: dwc3: trace: don't save pointers
There was another instance where we were
holding pointers which could be long gone.
Fix that by caching only values pointed to
by such pointer.
Because no crash has been observed, this patch
will be sent on v3.19 merge window, instead of
-rc.
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/dwc3/trace.h | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index 7a9d780..9fc20b3 100644 --- a/drivers/usb/dwc3/trace.h +++ b/drivers/usb/dwc3/trace.h @@ -175,17 +175,21 @@ DECLARE_EVENT_CLASS(dwc3_log_gadget_ep_cmd, TP_STRUCT__entry( __dynamic_array(char, name, DWC3_MSG_MAX) __field(unsigned int, cmd) - __field(struct dwc3_gadget_ep_cmd_params *, params) + __field(u32, param0) + __field(u32, param1) + __field(u32, param2) ), TP_fast_assign( snprintf(__get_str(name), DWC3_MSG_MAX, "%s", dep->name); __entry->cmd = cmd; - __entry->params = params; + __entry->param0 = params->param0; + __entry->param1 = params->param1; + __entry->param2 = params->param2; ), TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x", __get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd), - __entry->cmd, __entry->params->param0, - __entry->params->param1, __entry->params->param2 + __entry->cmd, __entry->param0, + __entry->param1, __entry->param2 ) ); |