summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-21 10:41:06 (GMT)
committerLinus Walleij <linus.walleij@linaro.org>2015-12-26 21:28:24 (GMT)
commitf2e13d2f6aaef281716db1fbe94ecb54fbfe5083 (patch)
tree7bc49b541318d02a1b0943edfad21b466e76024d
parent8a240c311715c2e34f9a8d6e69d6f85a9f484c6d (diff)
downloadlinux-f2e13d2f6aaef281716db1fbe94ecb54fbfe5083.tar.xz
gpio: sx150x: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. This also starts to propagate the error code from the I2C transaction as the end of the series adds support for that. Cc: Wei Chen <Wei.Chen@csr.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/gpio/gpio-sx150x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-sx150x.c b/drivers/gpio/gpio-sx150x.c
index 2d88296..04d4f2c 100644
--- a/drivers/gpio/gpio-sx150x.c
+++ b/drivers/gpio/gpio-sx150x.c
@@ -344,7 +344,7 @@ static int sx150x_gpio_get(struct gpio_chip *gc, unsigned offset)
mutex_unlock(&chip->lock);
}
- return status;
+ return (status < 0) ? status : !!status;
}
static void sx150x_gpio_set(struct gpio_chip *gc, unsigned offset, int val)