diff options
| author | NeilBrown <neilb@suse.de> | 2015-03-22 22:52:48 (GMT) |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2015-05-26 15:44:06 (GMT) |
| commit | f5e4edb8c888958a970b2d42c47d2871a1a4fcdf (patch) | |
| tree | 52f6424eac196fe27c5b21f9f9ba88ae7024fcd3 /Documentation/devicetree/bindings/power | |
| parent | e842b84c8e7221c45c8dbd7de09185c6149e1cf9 (diff) | |
| download | linux-f5e4edb8c888958a970b2d42c47d2871a1a4fcdf.tar.xz | |
power: twl4030_charger: find associated phy by more reliable means.
twl4030_charger currently finds the associated phy
using usb_get_phy() which will return the first USB2 phy.
If your platform has multiple such phys (as mine does),
this is not reliable (and reliably fails on the GTA04).
Change to use devm_usb_get_phy_by_node(), having found the
node by looking for an appropriately named sibling in
device-tree.
This makes usb-charging dependent on correct device-tree
configuration.
Acked-By: Sebastian Reichel <sre@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'Documentation/devicetree/bindings/power')
| -rw-r--r-- | Documentation/devicetree/bindings/power/twl-charger.txt | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/Documentation/devicetree/bindings/power/twl-charger.txt b/Documentation/devicetree/bindings/power/twl-charger.txt index d5c7062..3b4ea1b 100644 --- a/Documentation/devicetree/bindings/power/twl-charger.txt +++ b/Documentation/devicetree/bindings/power/twl-charger.txt @@ -1,5 +1,15 @@ TWL BCI (Battery Charger Interface) +The battery charger needs to interact with the USB phy in order +to know when charging is permissible, and when there is a connection +or disconnection. + +The choice of phy cannot be configured at a hardware level, so there +is no value in explicit configuration in device-tree. Rather +if there is a sibling of the BCI node which is compatible with +"ti,twl4030-usb", then that is used to determine when and how +use USB power for charging. + Required properties: - compatible: - "ti,twl4030-bci" |