summaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-08-05 02:08:31 (GMT)
committerGuenter Roeck <linux@roeck-us.net>2014-08-06 00:48:52 (GMT)
commit5b963089161b8fb244889c972edf553b9d737545 (patch)
treed512add2afcc03879f3cb2581a2f5a32db6a0c93 /Documentation
parentf4d33337eac4007793ca11fd1ab68d91ce7aa762 (diff)
downloadlinux-5b963089161b8fb244889c972edf553b9d737545.tar.xz
hwmon: (lm92) Prevent overflow problem when writing large limits
On platforms with sizeof(int) < sizeof(long), writing a temperature limit larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from long to int to fix the problem. The hysteresis temperature range depends on the value of data->temp[attr->index], since val is subtracted from it. Use a wider clamp, [-120000, 220000] should do to cover the possible range. Also add missing TEMP_TO_REG() on writes into cached hysteresis value. Also uses clamp_val to simplify the code a bit. Signed-off-by: Axel Lin <axel.lin@ingics.com> [Guenter Roeck: Fixed double TEMP_TO_REG on hysteresis updates] Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions