summaryrefslogtreecommitdiff
path: root/Makefile
diff options
context:
space:
mode:
authorNikolay Aleksandrov <nikolay@redhat.com>2014-02-26 13:20:30 (GMT)
committerDavid S. Miller <davem@davemloft.net>2014-02-26 22:09:09 (GMT)
commitee6154e11eeccd4ae32c4881415dbd902a869592 (patch)
treeee61b4fe5ed2665a595d9119afe433608c19e21e /Makefile
parente5fe0cd442e50f156bb54f5385b19eda50a13ccd (diff)
downloadlinux-ee6154e11eeccd4ae32c4881415dbd902a869592.tar.xz
bonding: fix a div error caused by the slave release path
There's a bug in the slave release function which leads the transmit functions which use the bond->slave_cnt to a div by 0 because we might just have released our last slave and made slave_cnt == 0 but at the same time we may have a transmitter after the check for an empty list which will fetch it and use it in the slave id calculation. Fix it by moving the slave_cnt after synchronize_rcu so if this was our last slave any new transmitters will see an empty slave list which is checked after rcu lock but before calling the mode transmit functions which rely on bond->slave_cnt. Fixes: 278b208375 ("bonding: initial RCU conversion") CC: Veaceslav Falico <vfalico@redhat.com> CC: Andy Gospodarek <andy@greyhouse.net> CC: Jay Vosburgh <fubar@us.ibm.com> CC: David S. Miller <davem@davemloft.net> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Acked-by: Veaceslav Falico <vfalico@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions