diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-07-01 17:02:22 (GMT) |
|---|---|---|
| committer | Russell King <rmk+kernel@armlinux.org.uk> | 2016-07-02 10:02:13 (GMT) |
| commit | dd665be0e243873343a28e18f9f345927b658daf (patch) | |
| tree | 6a56e14cb09bb48f651780c6aa093ab1e14d0ae9 /arch/arm/include/asm | |
| parent | 14c4a533e0996f95a0a64dfd0b6252d788cebc74 (diff) | |
| download | linux-dd665be0e243873343a28e18f9f345927b658daf.tar.xz | |
ARM: 8584/1: floppy: avoid gcc-6 warning
gcc-6.0 warns about comparisons between two identical expressions,
which is what we get in the floppy driver when writing to the FD_DOR
register:
drivers/block/floppy.c: In function 'set_dor':
drivers/block/floppy.c:810:44: error: self-comparison always evaluates to true [-Werror=tautological-compare]
fd_outb(newdor, FD_DOR);
It would be nice to use a static inline function instead of the
macro, to avoid the warning, but we cannot do that because the
FD_DOR definition is incomplete at this point.
Adding a cast to (u32) is a harmless way to shut up the warning,
just not very nice.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/include/asm')
| -rw-r--r-- | arch/arm/include/asm/floppy.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/include/asm/floppy.h b/arch/arm/include/asm/floppy.h index f488255..85a34cc 100644 --- a/arch/arm/include/asm/floppy.h +++ b/arch/arm/include/asm/floppy.h @@ -17,7 +17,7 @@ #define fd_outb(val,port) \ do { \ - if ((port) == FD_DOR) \ + if ((port) == (u32)FD_DOR) \ fd_setdor((val)); \ else \ outb((val),(port)); \ |