diff options
author | Julia Lawall <julia@diku.dk> | 2008-07-22 19:38:18 (GMT) |
---|---|---|
committer | Avi Kivity <avi@qumranet.com> | 2008-07-27 08:35:32 (GMT) |
commit | cab7a1eeeb007be309cd99cf14407261a72d2418 (patch) | |
tree | 1a384bb77cd56512ba2b3a1c7ac83eacea0165ec /arch/s390 | |
parent | 5fdbcb9dd16f1e89ead127d3ee1a38e3a00cf1ea (diff) | |
download | linux-cab7a1eeeb007be309cd99cf14407261a72d2418.tar.xz |
KVM: ia64: Fix irq disabling leak in error handling code
There is a call to local_irq_restore in the normal exit case, so it would
seem that there should be one on an error return as well.
The semantic patch that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression l;
expression E,E1,E2;
@@
local_irq_save(l);
... when != local_irq_restore(l)
when != spin_unlock_irqrestore(E,l)
when any
when strict
(
if (...) { ... when != local_irq_restore(l)
when != spin_unlock_irqrestore(E1,l)
+ local_irq_restore(l);
return ...;
}
|
if (...)
+ {local_irq_restore(l);
return ...;
+ }
|
spin_unlock_irqrestore(E2,l);
|
local_irq_restore(l);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Diffstat (limited to 'arch/s390')
0 files changed, 0 insertions, 0 deletions