diff options
| author | Christian Borntraeger <borntraeger@de.ibm.com> | 2014-11-21 15:21:56 (GMT) |
|---|---|---|
| committer | Christian Borntraeger <borntraeger@de.ibm.com> | 2014-12-18 08:54:39 (GMT) |
| commit | 4218091cb45f601b889cd032e39fe6878a426e70 (patch) | |
| tree | 36f63ef018f6842f91b2118240cc6a144ef52571 /arch | |
| parent | 14cf3d977b80f5e355f8ac7547cf1b9ff9fb3e09 (diff) | |
| download | linux-4218091cb45f601b889cd032e39fe6878a426e70.tar.xz | |
mips/gup: Replace ACCESS_ONCE with READ_ONCE
ACCESS_ONCE does not work reliably on non-scalar types. For
example gcc 4.6 and 4.7 might remove the volatile tag for such
accesses during the SRA (scalar replacement of aggregates) step
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)
Change the gup code to replace ACCESS_ONCE with READ_ONCE.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/mips/mm/gup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/mm/gup.c b/arch/mips/mm/gup.c index 06ce17c..8aa50e3 100644 --- a/arch/mips/mm/gup.c +++ b/arch/mips/mm/gup.c @@ -30,7 +30,7 @@ retry: return pte; #else - return ACCESS_ONCE(*ptep); + return READ_ONCE(*ptep); #endif } |