diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2014-06-27 17:01:46 (GMT) |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2014-06-30 17:22:33 (GMT) |
| commit | fb6bab6a5ad46d00b5ffa22268f21df1cd7c59df (patch) | |
| tree | cf20fd01e563ee6a4b659d30ab48de0fb015f584 /arch | |
| parent | f786106e8081bbec57053fec7fcf25dc25d02144 (diff) | |
| download | linux-fb6bab6a5ad46d00b5ffa22268f21df1cd7c59df.tar.xz | |
tracing/uprobes: Fix the usage of uprobe_buffer_enable() in probe_event_enable()
The usage of uprobe_buffer_enable() added by dcad1a20 is very wrong,
1. uprobe_buffer_enable() and uprobe_buffer_disable() are not balanced,
_enable() should be called only if !enabled.
2. If uprobe_buffer_enable() fails probe_event_enable() should clear
tp.flags and free event_file_link.
3. If uprobe_register() fails it should do uprobe_buffer_disable().
Link: http://lkml.kernel.org/p/20140627170146.GA18332@redhat.com
Acked-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Fixes: dcad1a204f72 "tracing/uprobes: Fetch args before reserving a ring buffer"
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions