summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorMatthew R. Ochs <mrochs@linux.vnet.ibm.com>2016-08-09 23:39:18 (GMT)
committerMartin K. Petersen <martin.petersen@oracle.com>2016-08-19 02:39:45 (GMT)
commit41b99e1a30a6d04df7585905e5ffc7251099c6d3 (patch)
tree2c2c77449ebcf8210b656c6da613db39c594e401 /block
parenta850ced42916a9bf25f4595c744156e6b8b8f5c0 (diff)
downloadlinux-41b99e1a30a6d04df7585905e5ffc7251099c6d3.tar.xz
scsi: cxlflash: Avoid mutex when destroying context
Context information structures are protected by a mutex that is held when accessing/manipulating the context. When the code that manages these structures was authored, a decision was made to include taking the mutex as part of the allocation/initialization sequence and also handle the scenario where the mutex was already held when freeing the context. While not a problem outright, this design decision has been deemed as too flexible and the code should be made more rigid to avoid future bugs. In addition, further review of the code yields that the existing mutex manipulations in both of these context management paths are superfluous. This commit removes the obtaining of the context mutex in the context initialization routine and assumes the mutex is not held in the context free path. Inspired-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com> Acked-by: Manoj N. Kumar <manoj@linux.vnet.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions