summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2016-02-15 06:23:12 (GMT)
committerDave Chinner <david@fromorbit.com>2016-02-15 06:23:12 (GMT)
commite10de3723c53378e7cf441529f563c316fdc0dd3 (patch)
treea21990a6de7476c768ec5924ed5cb4d40d3efe5f /block
parentbfce7d2e2d5ee05e9d465888905c66a70a9c243c (diff)
downloadlinux-e10de3723c53378e7cf441529f563c316fdc0dd3.tar.xz
xfs: don't chain ioends during writepage submission
Currently we can build a long ioend chain during ->writepages that gets attached to the writepage context. IO submission only then occurs when we finish all the writepage processing. This means we can have many ioends allocated and pending, and this violates the mempool guarantees that we need to give about forwards progress. i.e. we really should only have one ioend being built at a time, otherwise we may drain the mempool trying to allocate a new ioend and that blocks submission, completion and freeing of ioends that are already in progress. To prevent this situation from happening, we need to submit ioends for IO as soon as they are ready for dispatch rather than queuing them for later submission. This means the ioends have bios built immediately and they get queued on any plug that is current active. Hence if we schedule away from writeback, the ioends that have been built will make forwards progress due to the plug flushing on context switch. This will also prevent context switches from creating unnecessary IO submission latency. We can't completely avoid having nested IO allocation - when we have a block size smaller than a page size, we still need to hold the ioend submission until after we have marked the current page dirty. Hence we may need multiple ioends to be held while the current page is completely mapped and made ready for IO dispatch. We cannot avoid this problem - the current code already has this ioend chaining within a page so we can mostly ignore that it occurs. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions