summaryrefslogtreecommitdiff
path: root/drivers/atm/nicstar.h
diff options
context:
space:
mode:
authorHugh Dickins <hughd@google.com>2011-12-31 19:44:01 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2011-12-31 19:48:28 (GMT)
commite6780f7243eddb133cc20ec37fa69317c218b709 (patch)
tree81e427161f0604a8935180f8c454593142c0f272 /drivers/atm/nicstar.h
parent06867fbb8abc936192195e5dcc4b63e12cc78f72 (diff)
downloadlinux-e6780f7243eddb133cc20ec37fa69317c218b709.tar.xz
futex: Fix uninterruptible loop due to gate_area
It was found (by Sasha) that if you use a futex located in the gate area we get stuck in an uninterruptible infinite loop, much like the ZERO_PAGE issue. While looking at this problem, PeterZ realized you'll get into similar trouble when hitting any install_special_pages() mapping. And are there still drivers setting up their own special mmaps without page->mapping, and without special VM or pte flags to make get_user_pages fail? In most cases, if page->mapping is NULL, we do not need to retry at all: Linus points out that even /proc/sys/vm/drop_caches poses no problem, because it ends up using remove_mapping(), which takes care not to interfere when the page reference count is raised. But there is still one case which does need a retry: if memory pressure called shmem_writepage in between get_user_pages_fast dropping page table lock and our acquiring page lock, then the page gets switched from filecache to swapcache (and ->mapping set to NULL) whatever the refcount. Fault it back in to get the page->mapping needed for key->shared.inode. Reported-by: Sasha Levin <levinsasha928@gmail.com> Signed-off-by: Hugh Dickins <hughd@google.com> Cc: stable@vger.kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/atm/nicstar.h')
0 files changed, 0 insertions, 0 deletions