summaryrefslogtreecommitdiff
path: root/drivers/base
diff options
context:
space:
mode:
authorMagnus Damm <damm@opensource.se>2011-11-09 23:44:10 (GMT)
committerRafael J. Wysocki <rjw@sisk.pl>2011-11-09 23:44:10 (GMT)
commit24050956e029a9ecff096e1992869ada4492963c (patch)
tree096341c4741fcc967645578af0acb277f9754501 /drivers/base
parent056879d2f244001b2888cdc8cf868c33ca8b23a0 (diff)
downloadlinux-24050956e029a9ecff096e1992869ada4492963c.tar.xz
PM / Clocks: Only disable enabled clocks in pm_clk_suspend()
Refrain from running clk_disable() on clocks that have not been enabled. A typical case when this can happen is during Suspend-to-RAM for devices that have no driver associated with them. In such case the clock may be in default ACQUIRED state. Without this patch the sh7372 Mackerel board crashes in __clk_disable() during Suspend-to-RAM with: "Trying to disable clock 0xdeadbeef with 0 usecount" This happens for the CEU device which is added during boot. The test case has no CEU driver included in the kernel configuration. Needed for v3.2-rc1. Signed-off-by: Magnus Damm <damm@opensource.se> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/power/clock_ops.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 5f0f85d..428e55e 100644
--- a/drivers/base/power/clock_ops.c
+++ b/drivers/base/power/clock_ops.c
@@ -229,7 +229,8 @@ int pm_clk_suspend(struct device *dev)
list_for_each_entry_reverse(ce, &psd->clock_list, node) {
if (ce->status < PCE_STATUS_ERROR) {
- clk_disable(ce->clk);
+ if (ce->status == PCE_STATUS_ENABLED)
+ clk_disable(ce->clk);
ce->status = PCE_STATUS_ACQUIRED;
}
}