summaryrefslogtreecommitdiff
path: root/drivers/block/rsxx/core.c
diff options
context:
space:
mode:
authorKeith Busch <keith.busch@intel.com>2015-03-31 16:37:17 (GMT)
committerJens Axboe <axboe@fb.com>2015-03-31 16:39:56 (GMT)
commit1efccc9ddb98fd533169669160201b027562af7e (patch)
tree6d7680fe16e50bb0fdd72e41d312accd80634fc7 /drivers/block/rsxx/core.c
parentfda631ffe5422424579e1649e04cc468d0215b85 (diff)
downloadlinux-1efccc9ddb98fd533169669160201b027562af7e.tar.xz
NVMe: Fix blk-mq hot cpu notification
The driver may issue commands to a device that may never return, so its request_queue could always have active requests while the controller is running. Waiting for the queue to freeze could block forever, which is what blk-mq's hot cpu notification handler was doing when nvme drives were in use. This has the nvme driver make the asynchronous event command's tag reserved and does not keep the request active. We can't have more than one since the request is released back to the request_queue before the command is completed. Having only one avoids potential tag collisions, and reserving the tag for this purpose prevents other admin tasks from reusing the tag. I also couldn't think of a scenario where issuing AEN requests single depth is worse than issuing them in batches, so I don't think we lose anything with this change. As an added bonus, doing it this way removes "Cancelling I/O" warnings observed when unbinding the nvme driver from a device. Reported-by: Yigal Korman <yigal@plexistor.com> Signed-off-by: Keith Busch <keith.busch@intel.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/block/rsxx/core.c')
0 files changed, 0 insertions, 0 deletions