diff options
| author | Tejun Heo <tj@kernel.org> | 2011-04-21 19:32:55 (GMT) |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2011-04-21 19:33:05 (GMT) |
| commit | 9fd097b14918875bd6f125ed699d7bbbba5893ee (patch) | |
| tree | a7d58268cbcfaeeddc7fdf75bf0742dc63434a46 /drivers/block/swim3.c | |
| parent | 91e8549bde9e5cc88c5a2e8c8114389279e240b5 (diff) | |
| download | linux-9fd097b14918875bd6f125ed699d7bbbba5893ee.tar.xz | |
block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers
In-kernel disk event polling doesn't matter for legacy/fringe drivers
and may lead to infinite event loop if ->check_events() implementation
generates events on level condition instead of edge.
Now that block layer supports suppressing exporting unlisted events,
simply leaving disk->events cleared allows these drivers to keep the
internal revalidation behavior intact while avoiding weird
interactions with userland event handler.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/block/swim3.c')
| -rw-r--r-- | drivers/block/swim3.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c index 4c10f56..773bfa7 100644 --- a/drivers/block/swim3.c +++ b/drivers/block/swim3.c @@ -1163,7 +1163,6 @@ static int __devinit swim3_attach(struct macio_dev *mdev, const struct of_device disk->major = FLOPPY_MAJOR; disk->first_minor = i; disk->fops = &floppy_fops; - disk->events = DISK_EVENT_MEDIA_CHANGE; disk->private_data = &floppy_states[i]; disk->queue = swim3_queue; disk->flags |= GENHD_FL_REMOVABLE; |