diff options
author | Mike Frysinger <vapier@gentoo.org> | 2009-07-17 17:13:21 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-07-17 17:13:21 (GMT) |
commit | 0741241c6b80bfd58417e95de984d60c9e9ef2a0 (patch) | |
tree | 9fa70e5e918e0735c531988f64b92cb5655baf28 /drivers/connector/cn_queue.c | |
parent | e36aa25a533962b08402530e8443ac804a454e27 (diff) | |
download | linux-0741241c6b80bfd58417e95de984d60c9e9ef2a0.tar.xz |
connector: make callback argument type explicit
The connector documentation states that the argument to the callback
function is always a pointer to a struct cn_msg, but rather than encode it
in the API itself, it uses a void pointer everywhere. This doesn't make
much sense to encode the pointer in documentation as it prevents proper C
type checking from occurring and can easily allow people to use the wrong
pointer type. So convert the argument type to an explicit struct cn_msg
pointer.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/connector/cn_queue.c')
-rw-r--r-- | drivers/connector/cn_queue.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c index c769ef2..d478aef 100644 --- a/drivers/connector/cn_queue.c +++ b/drivers/connector/cn_queue.c @@ -87,7 +87,9 @@ void cn_queue_wrapper(struct work_struct *work) kfree(d->free); } -static struct cn_callback_entry *cn_queue_alloc_callback_entry(char *name, struct cb_id *id, void (*callback)(void *)) +static struct cn_callback_entry * +cn_queue_alloc_callback_entry(char *name, struct cb_id *id, + void (*callback)(struct cn_msg *)) { struct cn_callback_entry *cbq; @@ -120,7 +122,8 @@ int cn_cb_equal(struct cb_id *i1, struct cb_id *i2) return ((i1->idx == i2->idx) && (i1->val == i2->val)); } -int cn_queue_add_callback(struct cn_queue_dev *dev, char *name, struct cb_id *id, void (*callback)(void *)) +int cn_queue_add_callback(struct cn_queue_dev *dev, char *name, struct cb_id *id, + void (*callback)(struct cn_msg *)) { struct cn_callback_entry *cbq, *__cbq; int found = 0; |