summaryrefslogtreecommitdiff
path: root/drivers/dca
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2014-09-24 19:51:06 (GMT)
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-09-25 15:13:40 (GMT)
commit1b11629737ca5414b0310d35e01a125cfde1ba4d (patch)
treef511f76878ea67939db24d1cc622cd6ef81a282d /drivers/dca
parentee0d68ab5f0997a500fdf90924a58e787b216292 (diff)
downloadlinux-1b11629737ca5414b0310d35e01a125cfde1ba4d.tar.xz
drm: Drop grab fpriv->fbs_lock in drm_fb_release
Paulo Zanoni reported a lockdep splat with a locking inversion between fpriv->fbs_lock and the modeset locks. This issue was introduced in commit f2b50c1161590c3bcdbf3455fe4c575f1c1bd293 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Fri Sep 12 17:07:32 2014 +0200 drm: Fixup locking for universal cursor planes This here is actually one of the rare cases where lockdep hits a false positive: The deadlock only happens in drm_fb_release, which cleans up the file private structure when all the references are gone. So the locking is the very last one and no one else can deadlock. It also doesn't protect anything at all, since all ioctls are guaranteed to have returned at this point - otherwise they'd still hold a reference on the file. So let's just drop it and replace it with a big comment. Cc: David Herrmann <dh.herrmann@gmail.com> Cc: Matt Roper <matthew.d.roper@intel.com> Cc: Paulo Zanoni <przanoni@gmail.com> Reported-and-Tested-by: Paulo Zanoni <przanoni@gmail.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'drivers/dca')
0 files changed, 0 insertions, 0 deletions